version: latest does not actually retrieve the latest version #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
versionis set tolatest(or not specified and falls back to its default value) it fetches the phar from the following URL:phpcs/phpcs-action.bash
Line 8 in dfdd77a
The code behind that automagically maps the highest semver number to latest. The list of available versions is seeded from the repo's tags.
Due to reasons development of
squizlabs/php_codesnifferhas moved from https://github.com/squizlabs/PHP_CodeSniffer to https://github.com/PHPCSStandards/PHP_CodeSnifferThe newest tag available in the squizlabs repo is 3.7.2. The newest version available on Packagist as of this writing is 3.9.1. All versions after 3.7.2 were tagged in the PHPCSStandards org. Therefore, this PR moves the pulling of phar files from the
squizlabsrepo to thePHPCSStandardsrepo.Long term the proper solution would be to get this data from packagist and the only reason I didn't open a PR for that is the output does not offer a direct link to a phar. Note also that this particular package is (confusingly) defined as a virtual package as well.